Add nimble file #13

penguinite · 2025-05-23T09:34:17-05:00

penguinite commented

2025-05-23 09:34:17 -05:00

Fixes #12

Feel free to change the nimble file if you wish.

Fixes #12 Feel free to change the nimble file if you wish.

❤️ 1

penguinite added 1 commit 2025-05-23 09:34:18 -05:00

1706aa1945

Add nimble file

ITwrx commented

2025-05-23 10:22:49 -05:00

Thanks for your contribution!
It seems edit file got added in gitea 1.22 and i'm still a couple versions back... Your nimble file looks correct except i have FMN licensed as agplv3 as opposed to agplv3-or-later (for OCD reasons, lol). also, I don't think i used that datetime lib referenced in your nimble anywhere. If you saw the datetime import in /helpers/reminder, that was referring to /helpers/datetime, though i see that is not terribly clear. If you wanted to address those issues i could just merge your PR. Thanks!

Thanks for your contribution! It seems `edit file` got added in gitea 1.22 and i'm still a couple versions back... Your nimble file looks correct except i have FMN licensed as `agplv3` as opposed to `agplv3-or-later` (for OCD reasons, lol). also, I don't think i used that datetime lib referenced in your nimble anywhere. If you saw the `datetime` import in `/helpers/reminder`, that was referring to `/helpers/datetime`, though i see that is not terribly clear. If you wanted to address those issues i could just merge your PR. Thanks!

penguinite commented

2025-05-23 10:33:17 -05:00

Ah! I'll quickly correct the PR.

Do you want me to try to squash the commits or is it fine if it's the whole PR is in two commits?

Ah! I'll quickly correct the PR. Do you want me to try to squash the commits or is it fine if it's the whole PR is in two commits?

penguinite added 1 commit 2025-05-23 10:34:49 -05:00

75a1239ab7

Fix issues in nimble file

ITwrx commented

2025-05-23 10:51:16 -05:00

well, i now see that i only created the release branch here in gitea, due to sensitive items being hardcoded into the program otherwise (local master branch). The plan was to eventually use config files for sensitive keys, creds, etc and have those loaded at runtime, but i haven't done that yet. I just created a contrib-dev branch for contributions to go into. I wonder how to move your pr over to that branch? Sorry if i screwed up your work flow. I'm barely used to my own simplified git workflow. :)

well, i now see that i only created the release branch here in gitea, due to sensitive items being hardcoded into the program otherwise (local master branch). The plan was to eventually use config files for sensitive keys, creds, etc and have those loaded at runtime, but i haven't done that yet. I just created a `contrib-dev` branch for contributions to go into. I wonder how to move your pr over to that branch? Sorry if i screwed up your work flow. I'm barely used to my own simplified git workflow. :)

ITwrx changed target branch from release-0.9.0 to contrib-dev

2025-05-23 10:54:44 -05:00

ITwrx merged commit 2c5a6d627c into contrib-dev

2025-05-23 10:55:18 -05:00

ITwrx referenced this issue from a commit

2025-05-23 10:55:20 -05:00

Merge pull request 'Add nimble file' (#13) from penguinite/Forget-Me-Not:release-0.9.0 into contrib-dev

ITwrx commented

2025-05-23 10:59:19 -05:00

Yay me! I used a "Search Engine"! lol. Thanks again for your contribution. I will reorganize the code to make that nimble file actually work upon next release.

Sign in to join this conversation.

No reviewers