ITwrxOrg/Forget-Me-Not
1
0
Fork 1
generated from ITwrxOrg/EZ-Bkup
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Add nimble file #13

Merged
ITwrx merged 2 commits from penguinite/Forget-Me-Not:release-0.9.0 into contrib-dev 2025-05-23 10:55:18 -05:00
Conversation 4 Commits 2 Files Changed 1 +19
penguinite commented 2025-05-23 09:34:18 -05:00
Contributor
Copy Link

PR adding a nimble file for Forget-Me-Not, contributed by penguinite. Merged into contrib-dev via commit 2c5a6d627c.

PR adding a nimble file for Forget-Me-Not, contributed by penguinite. Merged into contrib-dev via commit 2c5a6d627c3cdcc25071b8fe152b25bcc3d6ee5f.
❤️ 1
penguinite added 1 commit 2025-05-23 09:34:18 -05:00
Add nimble file 1706aa1945
ITwrx commented 2025-05-23 10:22:49 -05:00
Owner
Copy Link

Thanks for your contribution!
It seems edit file got added in gitea 1.22 and i'm still a couple versions back... Your nimble file looks correct except i have FMN licensed as agplv3 as opposed to agplv3-or-later (for OCD reasons, lol). also, I don't think i used that datetime lib referenced in your nimble anywhere. If you saw the datetime import in /helpers/reminder, that was referring to /helpers/datetime, though i see that is not terribly clear. If you wanted to address those issues i could just merge your PR. Thanks!

Thanks for your contribution! It seems `edit file` got added in gitea 1.22 and i'm still a couple versions back... Your nimble file looks correct except i have FMN licensed as `agplv3` as opposed to `agplv3-or-later` (for OCD reasons, lol). also, I don't think i used that datetime lib referenced in your nimble anywhere. If you saw the `datetime` import in `/helpers/reminder`, that was referring to `/helpers/datetime`, though i see that is not terribly clear. If you wanted to address those issues i could just merge your PR. Thanks!
penguinite commented 2025-05-23 10:33:17 -05:00
Author
Contributor
Copy Link

Ah! I'll quickly correct the PR.

Do you want me to try to squash the commits or is it fine if it's the whole PR is in two commits?

Ah! I'll quickly correct the PR. Do you want me to try to squash the commits or is it fine if it's the whole PR is in two commits?
penguinite added 1 commit 2025-05-23 10:34:49 -05:00
Fix issues in nimble file 75a1239ab7
ITwrx commented 2025-05-23 10:51:16 -05:00
Owner
Copy Link

well, i now see that i only created the release branch here in gitea, due to sensitive items being hardcoded into the program otherwise (local master branch). The plan was to eventually use config files for sensitive keys, creds, etc and have those loaded at runtime, but i haven't done that yet. I just created a contrib-dev branch for contributions to go into. I wonder how to move your pr over to that branch? Sorry if i screwed up your work flow. I'm barely used to my own simplified git workflow. :)

well, i now see that i only created the release branch here in gitea, due to sensitive items being hardcoded into the program otherwise (local master branch). The plan was to eventually use config files for sensitive keys, creds, etc and have those loaded at runtime, but i haven't done that yet. I just created a `contrib-dev` branch for contributions to go into. I wonder how to move your pr over to that branch? Sorry if i screwed up your work flow. I'm barely used to my own simplified git workflow. :)
ITwrx changed target branch from release-0.9.0 to contrib-dev 2025-05-23 10:54:44 -05:00
ITwrx merged commit 2c5a6d627c into contrib-dev 2025-05-23 10:55:18 -05:00
ITwrx commented 2025-05-23 10:59:19 -05:00
Owner
Copy Link

Yay me! I used a "Search Engine"! lol. Thanks again for your contribution. I will reorganize the code to make that nimble file actually work upon next release.

Yay me! I used a "Search Engine"! lol. Thanks again for your contribution. I will reorganize the code to make that nimble file actually work upon next release.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
?/support
Question/Support Request
 accepted
accepted and being worked on.
 bug/defect
not working as designed
 design flaw
working as designed, but design is flawed...
 design note
planning/discussion of how something should work
 duplicate
This issue or pull request already exists
 enhancement
New feature/capability
 fix in dev
This issue is fixed in a development branch but not included in a release yet.
 help wanted
Contributions appreciated!
 invalid
Not actionable as submitted.
 needs info
The issue requires more information for further action.
 rejected
Issue not accepted for implementation.
feedback?
Let us know what you think!
 investigating
Under initial investigation for validity and cause.
 low priority
Could be improved but not the end of the world and it might be a while before it's important enough to address.
 upstream
issue exists in a project that is upstream of EZ Bkup.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ITwrx
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ITwrxOrg/Forget-Me-Not#13
Delete Branch "penguinite/Forget-Me-Not:release-0.9.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?