generated from ITwrxOrg/EZ-Bkup
Why is output specified in config and also hardcoded in source? #2
Labels
No Label
?/support
accepted
bug/defect
design flaw
design note
duplicate
enhancement
fix in dev
help wanted
invalid
needs info
rejected
feedback?
investigating
low priority
upstream
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: ITwrxOrg/GoAccessReporter#2
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It looks like site.output is read from config, but never used. We probably started one way, changed course, and forgot to reconcile/clean up the old approach. output config item and related code was probably supposed to be removed for the hardcoded approach. If we do want the output location to be configurable, in case people wanted to run as different users with diff perms on log and report location, output needs to be used just for location, and not the whole output file name, as it currently is. Right now, the source code is using a hardcoded location, and generating the output file name with date included, which is better than a config'd static output file name with no date. This definitely got missed/not cleaned up.
Removing config item and related code for now. One less thing that can go wrong during user setup.